core: improve handling of /var/lib/stellar#154
Merged
jacekn merged 1 commit intostellar:mainfrom Mar 5, 2026
Merged
Conversation
This PR improves how /var/lib/stellar directory is handled. Currently if persistence is not enabled new-db runs in an empeheral container which means it doesn't have real effect. This change will use emptyDir if persistence is disabled which will allow core to start as normal. As drive-by I also bumped core version number
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes non-persistent /var/lib/stellar handling in the core StatefulSet when persistence is disabled, ensuring the new-db init container and the core container share the same storage, and bumps the chart/app versions accordingly.
Changes:
- Always mount
/var/lib/stellarin the init container and relevant containers, regardless of persistence setting. - Add an
emptyDirvolume for/var/lib/stellarwhencore.persistence.enabled=false(PVC still used when enabled). - Bump chart
versionandappVersion.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| charts/core/templates/core-sts.yaml | Ensures /var/lib/stellar is backed by emptyDir when persistence is off, while retaining PVC usage when on. |
| charts/core/Chart.yaml | Updates chart version and the default app version tag. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves how /var/lib/stellar directory is handled. Currently if persistence is not enabled new-db runs in an empeheral container which means it doesn't have real effect. This change will use emptyDir if persistence is disabled which will allow core to start as normal.
As drive-by I also bumped core version number